This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Avoid adding cnsi-list header to none portal-proxy requests #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the correct fix for now. However, we were planning on moving the Github API and models to the |
|
Yeah, as @ongk said this fix may not need once we have github related stuff moved out to its own plugin, but it is correct before it happens. |
richard-cox
added a commit
that referenced
this pull request
Oct 5, 2020
* WIP * First pass at permission effects * First pass at reducer * Final set of cloud-foundry code out of common * Renames, todos * Minor fixes * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes #4325 * Fix misaligned user button - fixes #4316 * Temporarily add branch v3.2.1 to travis * check sso whitelist in more places Signed-off-by: Ben Berry <ben.berry@gsa.gov> * refactor sso state checks into single function Signed-off-by: Ben Berry <ben.berry@gsa.gov> * Update version * First pass at changelog (additional SSO fix required) * Update changelog * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Fix package-lock.json * Remove v3.2.1 was .travis.taml * Remove need for --recreate-pods when upgrading * Update readme following move to Travis-ci.com * Add support for helm chart customizations * Removed change not needed * Ensure the correct key is used metacard favourite info (#4321) * Fix display of details in endpoint card in endpoint list (#4319) * Clean default/blocked logic * Rename @stratos to @stratosui * FIx references in tsconfig.json * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Fix for buildpack filename wrapping on card * Fix code climate issue * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Change following review * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com> * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Fail CI build if imagelist generation fails * Updated __stratos.tpl as per changes in deploy/kubernetes/console/templates/deployment.yaml * Fix build * Helm Chart: Icon is missing - fixes #393 * Fixes following review Co-authored-by: Ben Berry <ben.berry@gsa.gov> Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ongk I think this might be right. Could you take a look? There's an issue when calling out to github when extra headers are attached. This will stop the interceptor adding the header for any url not starting in pp.